Skip to content

fix: escape apostrophes in fingerprint globs#2875

Closed
cyphercodes wants to merge 1 commit into
go-task:mainfrom
cyphercodes:fix/apostrophe-path-generates
Closed

fix: escape apostrophes in fingerprint globs#2875
cyphercodes wants to merge 1 commit into
go-task:mainfrom
cyphercodes:fix/apostrophe-path-generates

Conversation

@cyphercodes

Copy link
Copy Markdown

Summary

  • Treat apostrophes in fingerprint glob paths as literal path characters before shell-style field expansion.
  • Add a regression test that runs a Taskfile from a temporary directory whose name contains an apostrophe, with both sources and generates configured.

Fixes #2874.

Tests

  • go test . -run TestStatusChecksumAllowsApostropheInWorkingDirectory -count=1
  • go test ./internal/fingerprint ./internal/execext . -count=1
  • go test ./...
  • git diff --check

AI assistance was used to help investigate and prepare this patch; I reviewed and tested the changes.

@trulede

trulede commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

This is not really a good solution. Would you mind coming up with something better.

@trulede trulede added the state: awaiting response Waiting for issue author to respond. label Jun 8, 2026
@trulede

trulede commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Close in favour of #2879

@trulede trulede closed this Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: awaiting response Waiting for issue author to respond.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"reached EOF without closing quote" when folder name has a quote in it

2 participants